[tor-bugs] #19571 [Metrics/metrics-lib]: Missing break statement in RelayNetworkStatusImpl
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Jul 5 13:24:00 UTC 2016
#19571: Missing break statement in RelayNetworkStatusImpl
-------------------------------------+---------------------
Reporter: karsten | Owner: karsten
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Metrics/metrics-lib | Version:
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
-------------------------------------+---------------------
Ugh, I just found a potential bug in
[https://trac.torproject.org/projects/tor/attachment/ticket/17824/0001-task-17824-addendum.patch
the patch attached to #17824]: The last switch case in
`RelayNetworkStatusImpl` doesn't contain a `break` statement and hence
falls through to the default case. This code is
[https://gitweb.torproject.org/metrics-
lib.git/tree/src/org/torproject/descriptor/impl/RelayNetworkStatusImpl.java#n143
still in master]. I didn't investigate yet what effects that has, but I
feel it might break things.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19571>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list