[tor-bugs] #17076 [Tor]: Improve coverage on src/or/config.c (options_validate)

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Jan 31 23:09:23 UTC 2016


#17076: Improve coverage on src/or/config.c (options_validate)
-------------------------------------------------+-------------------------
 Reporter:  rjunior                              |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  testing, 028-triaged,                |        Version:
  TorCoreTeam201602                              |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:  SponsorS                             |         Points:  small
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  testing, 028-triaged => testing, 028-triaged,
               TorCoreTeam201602


Comment:

 I cherry-picked ae6c5e8 from olabini's branch, and added three other
 correctness fixes:
 * correctly handle errors when parsing options
 * make all unit tests independent of log message order and count
 * fix potential buffer overrun in snprintf by using tor_snprintf
  * (On some platforms, snprintf automatically nul-terminates its string,
 and then returns the number of characters it wanted to write. Writing a
 nul to the position returned by snprintf is an error.)

 Please see my branch options_validate_second_round at
 https://github.com/teor2345/tor.git
 (Sorry for forgetting to include my github URL last time.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17076#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list