[tor-bugs] #18168 [Tor Browser]: Iframe based AJAX call blocked by popup-blocker or opening in new tab

[Tor Bug Tracker & Wiki]

#18168: Iframe based AJAX call blocked by popup-blocker or opening in new tab
-------------------------------------------------+-------------------------
 Reporter:  sky_kohai                            |          Owner:  mcs
     Type:  defect                               |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor Browser                          |      Milestone:
 Severity:  Major                                |        Version:
 Keywords:  tbb-usability-website,               |     Resolution:
  TorBrowserTeam201601R                          |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  needs_revision => needs_review


Comment:

 Here is a new patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug18168-02&id=4a83eab098f0064fa8e1ce55b729dc42e0dd4058

 Please review. We now avoid clearing window.name for all frames/iframes,
 which more closely matches the behavior of the original JavaScript
 implementation from Torbutton. Kathy and I tested this with all of the
 sites mentioned in this ticket and we added more automated tests, but more
 testing is welcome.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18168#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online