[tor-bugs] #18154 [Tor]: attempt to open a socket after DisableNetwork=1 transition

[Tor Bug Tracker & Wiki]

#18154: attempt to open a socket after DisableNetwork=1 transition
--------------------+---------------------
 Reporter:  mcs     |          Owner:
     Type:  defect  |         Status:  new
 Priority:  Medium  |      Milestone:
Component:  Tor     |        Version:
 Severity:  Normal  |     Resolution:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
  Sponsor:          |
--------------------+---------------------

Comment (by mcs):

 Replying to [comment:2 teor]:
 > This could be due to a race condition where Tor starts a network
 connection attempt before you issue the SETCONF, then the SETCONF
 completes, then the socket connection attempt occurs.
 >
 > I'm not sure what we can do to fix this, but we might be able to make
 the race harder to trigger.

 I am not very familiar with the tor internals, but I wonder how difficult
 it would be to gracefully shutdown/cleanup "in progress" connections
 during a transition to the "network disabled" state? In other words,
 during some short period of transition tor would not report an error but
 just close the socket, etc.

 > Are you using 0.2.8.0-alpha-dev in 6.0a1?
 > We refactored periodic events in 0.2.8, which might have made this race
 easier to trigger.

 TB 6.0a1 still uses 0.2.7.6:
  Jan 26 13:32:54.055 [notice] Tor v0.2.7.6 (git-7a489a6389110120) running
 on Darwin with Libevent 2.0.22-stable, OpenSSL 1.0.1q and Zlib 1.2.5.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18154#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online