[tor-bugs] #17592 [Tor]: Clean up connection timeout logic

[Tor Bug Tracker & Wiki]

#17592: Clean up connection timeout logic
-----------------------+------------------------------------
 Reporter:  mikeperry  |          Owner:  mikeperry
     Type:  defect     |         Status:  needs_revision
 Priority:  High       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor        |        Version:
 Severity:  Normal     |     Resolution:
 Keywords:             |  Actual Points:
Parent ID:  #16861     |         Points:
  Sponsor:             |
-----------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 * channelpadding_get_channel_idle_timeout():
      * The documentation for channelpadding_get_channel_idle_timeout
 should describe units.  It's seconds, right?
      * Should the magic numbers in the client-or-noncanonical case uses
 magic numbers.  Should it use a network parameter instead, like the other
 stuff?
      * Let's document what a "circuit idle timeout" is.
      * How come this one doesn't look at any optoins like
 channelpadding_get_circuits_available_timeout does?  Should it be looking
 at CircuitsAvailableTimeout?

   * channelpadding_get_circuits_available_timeout():
      * Let's also document in the function comment when this timeout
 controls exactly.

   * predicted_ports_prediction_time_remaining():
      * time_t differences are not guaranteed to fit into an int.

 General stuff:
   * Should we be looking at monotonic time for any of this?

 Otherwise looks good!  And also solid!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17592#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online