[tor-bugs] #18154 [Tor]: attempt to open a socket after DisableNetwork=1 transition

[Tor Bug Tracker & Wiki]

#18154: attempt to open a socket after DisableNetwork=1 transition
------------------------+-----------------
     Reporter:  mcs     |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:
    Component:  Tor     |    Version:
     Severity:  Normal  |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+-----------------
 Tor Browser 6.0a1 includes a change that was made as part of #11773 that
 causes Tor Launcher to immediately issue a SETCONF DisableNetwork=1
 command when the user cancels the bootstrapping process. Unfortunately,
 this causes tor to sometimes emit an error like this one:
 {{{
 650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=25 TAG=loading_status
 SUMMARY="Loading networkstatus consensus" WARNING="Network is unreachable"
 REASON=NOROUTE COUNT=1 RECOMMENDATION=warn
 HOSTID="0AD3FA884D18F89EEA2D89C019379E0E7FD94417"
 HOSTADDR="208.83.223.34:80"
 }}}
 And Tor Launcher displays an error alert.

 I cannot reproduce this when I enable debug logging in tor, but I can when
 info logging is enabled. In the tor log I see:
 {{{
 Jan 26 13:40:08.000 [warn] connection_connect_sockaddr(): Bug: Tried to
 open a socket with DisableNetwork set. (on Tor 0.2.7.6 7a489a6389110120)
 }}}

 I will attach a trace from Tor Launcher as well as the tor info log.

 Is this a tor bug? Or is there a better way for Tor Launcher to stop the
 bootstrapping process?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18154>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online