[tor-bugs] #18119 [Tor]: .onion domain names can be really short

[Tor Bug Tracker & Wiki]

#18119: .onion domain names can be really short
-----------------------------------+-------------------------------------
 Reporter:  azazar                 |          Owner:
     Type:  enhancement            |         Status:  closed
 Priority:  Medium                 |      Milestone:  Tor: very long term
Component:  Tor                    |        Version:
 Severity:  Normal                 |     Resolution:  wontfix
 Keywords:  tor-hs needs-proposal  |  Actual Points:
Parent ID:                         |         Points:
  Sponsor:                         |
-----------------------------------+-------------------------------------

Comment (by azazar):

 Replying to [comment:4 yawning]:


 > I don't think we use `alloca()` in the code, and it feels gratuitious
 when a pair of statically sized buffers will suffice.
 >
 > Blindly truncating down addresses assuming the shorted format when doing
 the comparsion probably leads to odd things happening to existing deployed
 HSes that happen to have a stream of `a`s at the end.

 Actually, this patch is backwards-compatible, all existing addresses
 should work as they did before. It translates only shortened addresses.
 What kind of odd things could happen?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18119#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online