[tor-bugs] #18126 [Tor]: Update RSOS extend_info_from_node calls to be direct connections

[Tor Bug Tracker & Wiki]

#18126: Update RSOS extend_info_from_node calls to be direct connections
------------------------+--------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor     |    Version:
     Severity:  Normal  |   Keywords:  rsos
Actual Points:          |  Parent ID:  #17178
       Points:          |    Sponsor:
------------------------+--------------------------------
 In rend_consider_services_intro_points() and find_rp_for_intro(), a RSOS
 calls extend_info_from_node() to get the node's address. Since it's making
 a direct connection, it should pass 1.

 This will enforce IP address preferences and other reachable address
 settings once #17840 is merged.

 Hidden services should continue to pass 0.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18126>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online