[tor-bugs] #18119 [Tor]: .onion domain names can be really short

[Tor Bug Tracker & Wiki]

#18119: .onion domain names can be really short
-----------------------------------+-------------------------------------
 Reporter:  azazar                 |          Owner:
     Type:  enhancement            |         Status:  needs_revision
 Priority:  Medium                 |      Milestone:  Tor: very long term
Component:  Tor                    |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  tor-hs needs-proposal  |  Actual Points:
Parent ID:                         |         Points:
  Sponsor:                         |
-----------------------------------+-------------------------------------
Changes (by yawning):

 * keywords:  tor-hs => tor-hs needs-proposal


Comment:

 Inclined to NACK due to 224 making this totally worthless in any
 meaningful manner, and before this has a chance of getting merged despite
 my objections, a change like this will need to go through the proposal
 process.

 I don't think we use `alloca()` in the code, and it feels gratuitious when
 a pair of statically sized buffers will suffice.

 Blindly truncating down addresses assuming the shorted format when doing
 the comparsion probably leads to odd things happening to existing deployed
 HSes that happen to have a stream of `a`s at the end.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18119#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online