[tor-bugs] #18113 [Tor Launcher]: Dynamically allocate clients to default Tor Browser bridges of a certain type

[Tor Bug Tracker & Wiki]

#18113: Dynamically allocate clients to default Tor Browser bridges of a certain
type
--------------------------------------+------------------------------
 Reporter:  isis                      |          Owner:  brade
     Type:  enhancement               |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Tor Launcher              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-bridges tor-launcher  |  Actual Points:
Parent ID:                            |         Points:
  Sponsor:                            |
--------------------------------------+------------------------------

Comment (by mcs):

 Replying to [comment:4 isis]:
 > The patch is in my `bug18113` [https://github.com/isislovecruft/tor-
 launcher/tree/bug18113 branch].

 I cannot comment on whether this is a good idea and whether persistent
 state is needed, but the Tor Launcher changes look OK. Just a couple of
 minor comments that can be addressed later if there is not time right now:
 1. Since the rearrangeBridges() function is only used inside tl-util.jsm,
 we should move it to the TLUtilInternal object (and rename it to
 _rearrangeBridges).
 2. I would have used Math.floor() instead of parseInt() but either one
 works.
 3. From a style perspective, I do not really like how everything is
 embedded inside the final for loop expression. It seems like excessive use
 of the comma operator and I find it harder to read than if something was
 in the loop body.

 Just so it is clear: this patch will cause the default set of bridges to
 be used in a different order each time Tor Browser is restarted or
 reconfigured.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18113#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online