[tor-bugs] #18100 [Tor]: src/or/connection_edge.c typo

[Tor Bug Tracker & Wiki]

#18100: src/or/connection_edge.c typo
----------------------------------------+----------------------------------
 Reporter:  jirib                       |          Owner:
     Type:  defect                      |         Status:  needs_review
 Priority:  Medium                      |      Milestone:  Tor:
Component:  Tor                         |  0.2.8.x-final
 Severity:  Normal                      |        Version:  Tor:
 Keywords:  027-backport, 026-backport  |  0.2.6.3-alpha
Parent ID:                              |     Resolution:
  Sponsor:                              |  Actual Points:
                                        |         Points:
----------------------------------------+----------------------------------
Changes (by teor):

 * status:  new => needs_review
 * keywords:   => 027-backport, 026-backport
 * version:   => Tor: 0.2.6.3-alpha
 * milestone:   => Tor: 0.2.8.x-final


Comment:

 This appears to be due to a8835170d710cae0ac1e8698cd5b750077025548 on 4
 Feb 2015, released in 0.2.6.3-alpha.

 Also in the same commit, connection_ap_get_original_destination doesn't
 have any code to call destination_from_socket when TRANS_TPROXY is
 defined. This is most likely a bug, too.

 Please see my branch bug18100-v2 on https://github.com/teor2345/tor.git

 It's based on maint-0.2.6 and split it into several commits, in order of
 importance:
 * Make connection_ap_get_original_destination & destination_from_socket
 work with TRANS_TPROXY
 * Make destination_from_socket only call the TRANS_PF code under
 TPT_PF_DIVERT
 * Clean up error handling and logging code

 There's still some duplicate getsockname code in destination_from_socket,
 split off into #18105 (it's tough to get rid of, and not worth
 backporting).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18100#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online