[tor-bugs] #18022 [Tor bundles/installation]: start-tor-browser.desktop parameter passing broken on spaces

[Tor Bug Tracker & Wiki]

#18022: start-tor-browser.desktop parameter passing broken on spaces
--------------------------------------+------------------------------
 Reporter:  adrelanos                 |          Owner:  erinn
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Tor bundles/installation  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201601R     |  Actual Points:
Parent ID:                            |         Points:
  Sponsor:                            |
--------------------------------------+------------------------------
Changes (by gk):

 * keywords:  tbb-5.5 => TorBrowserTeam201601R


Comment:

 Replying to [comment:2 adrelanos]:
 > Likely the bug lies in:
 > https://gitweb.torproject.org/builders/tor-browser-
 bundle.git/tree/RelativeLink/execdesktop
 >
 > The following line seems wrong.
 >
 > {{{
 > eval "${TBB_START_PROG} $@"
 > }}}
 >
 > Replacing it with the following does the trick.
 >
 > {{{
 > eval "${TBB_START_PROG}" \'$@\'
 > }}}
 >
 > If that looks sane to you, could you please apply it to git?

 That's not working for me if I do things like `./start-tor-browser.desktop
 --debug --log`. So, it seems for Tor Browser 5.5 you need to use `start-
 tor-browser` directly which seems like a good idea anyway.

 The execdesktop "rewrites" should get tested in the alpha series first, I
 think (in case one of the proposals passes review).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18022#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online