[tor-bugs] #18050 [Tor]: Relay submitted a descriptor with 0 DirPort due to a self-test race condition

[Tor Bug Tracker & Wiki]

#18050: Relay submitted a descriptor with 0 DirPort due to a self-test race
condition
----------------------------------------+----------------------------------
 Reporter:  teor                        |          Owner:
     Type:  defect                      |         Status:  needs_review
 Priority:  Medium                      |      Milestone:  Tor:
Component:  Tor                         |  0.2.8.x-final
 Severity:  Normal                      |        Version:  Tor: 0.2.6.10
 Keywords:  026-backport, 027-backport  |     Resolution:
Parent ID:                              |  Actual Points:
  Sponsor:                              |         Points:
----------------------------------------+----------------------------------
Changes (by teor):

 * keywords:  026-maybe-backport, 027-maybe-backport => 026-backport,
     027-backport
 * status:  new => needs_review


Comment:

 Please see my branch bug18050 based on maint-0.2.6 on
 https://github.com/teor2345/tor.git

 The commit merges cleanly into maint-0.2.7 and master.
 The unit tests and make test-network[-all] pass on maint-0.2.6,
 maint-0.2.7, and master.
 It also passes `src/test/test-network.sh --sleep 600` on master with
 AssumeReachable 0 (chutney usually has AssumeReachable 1, which disables
 reachability checking).

 The fix is a one-line change to decide_if_publishable_server() to restore
 the original intent of a1f1fa6ab in 0.1.0.1-rc. From that commit message:

     Try to pull down a directory via Tor to see if our DirPort is working.
     Try to extend a circuit back to us to see if our ORPort is working.
     Only publish a descriptor if they're both reachable.

 It then makes consequential changes to log messages and the function
 comment to make the new behaviour clear.

 If we decide to backport this, we don't need to do a release for this fix.
 It just needs to be included in the next minor release in each series, to
 avoid relay version upgrades triggering this bug.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18050#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online