[tor-bugs] #17127 [Tor]: Fix and re-enable --master-key option, possibly --out (for keys) and possibly --nopass for non-interactive key generation

[Tor Bug Tracker & Wiki]

#17127: Fix and re-enable --master-key option, possibly --out (for keys) and
possibly --nopass for non-interactive key generation
-------------------------+------------------------------------
 Reporter:  nickm        |          Owner:
     Type:  enhancement  |         Status:  new
 Priority:  Medium       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:  028-triaged  |  Actual Points:
Parent ID:               |         Points:  small/medium
  Sponsor:  SponsorU     |
-------------------------+------------------------------------

Comment (by s7r):

 Since `--master-key` and `--out` are meant to split in 2 the attributes of
 `--DataDirectory` and eliminate the requirement of of a "keys" subfolder,
 we should code it in a way that these cannot be used together, to avoid
 confusions.

 `--DataDirectory` will expect to find the master identity key in the given
 path under a "keys" subfolder under the filename
 "ed25519_master_id_secret_key" or "ed25519_master_id_secret_key_encrypted"
 and save all the output files in the same place.

 `--master-key` and `--out` will require a direct path to the master
 identity key that can have any filename and a direct path for saving the
 output files. Might as well treat `--master-key` and `--out` dependent on
 each other.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17127#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online