[tor-bugs] #17852 [Tor]: Tor Daemon hardening: Fix complaints from FlawFinder.

[Tor Bug Tracker & Wiki]

#17852: Tor Daemon hardening: Fix complaints from FlawFinder.
----------------------+------------------------------------
 Reporter:  jsturgix  |          Owner:
     Type:  defect    |         Status:  needs_review
 Priority:  Medium    |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor       |        Version:  Tor: 0.2.7
 Severity:  Normal    |     Resolution:
 Keywords:            |  Actual Points:
Parent ID:            |         Points:
  Sponsor:            |
----------------------+------------------------------------
Changes (by jsturgix):

 * status:  needs_revision => needs_review


Comment:

 Sorry so much time has passed before attempting a revision....

 86a5305d46175c5d0c67564d3ee4e86a27f0c460:
 . This commit changes several snprintf() to tor_snprintf().  Is the
 comment about strlcat() only working if UNICODE not defined apply to a
 specific change or all of them?  I'm probably missing something obvious,
 but where is the tie to strlcat()?

 28241bd4b47bdf4616a237f1bf28c9d65c9373af:
 . I reverted some changes that should follow the CPD_CHECK semantics
 correctly.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17852#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online