[tor-bugs] #17573 [Tor]: Update max_dl_per_request for IPv6 address length

[Tor Bug Tracker & Wiki]

#17573: Update max_dl_per_request for IPv6 address length
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  easy, ipv6, TorCoreTeam201601,       |        Version:
  201512-deferred                                |     Resolution:
Parent ID:  #17811                               |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------
Changes (by fergus):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:8 teor]:
 > * the original calculation was missing the port, which can be up to 6
 characters extra: ":65535". Let's fix this existing bug while we're at it.

 > * As far as I can tell, the IPv6 address should be in square brackets,
 to avoid ambiguity with an added ":port".
 The actual request in {{{directory_send_command}}} won't include the
 square brackets because {{{tor_dup_addr}}} doesn't take a decorate
 parameter to pass to {{{tor_addr_to_str}}}. This is probably a bug.

 I've pushed a commit fixing both of these.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17573#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online