[tor-bugs] #17076 [Tor]: Improve coverage on src/or/config.c (options_validate)

[Tor Bug Tracker & Wiki]

#17076: Improve coverage on src/or/config.c (options_validate)
----------------------------------+------------------------------------
 Reporter:  rjunior               |          Owner:
     Type:  enhancement           |         Status:  needs_review
 Priority:  Medium                |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                   |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  testing, 028-triaged  |  Actual Points:
Parent ID:                        |         Points:  small
  Sponsor:  SponsorS              |
----------------------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [comment:16 olabini]:
 > Thank you, I didn't find those functions when looking for something
 suitable. The branch is now updated to use those instead.

 I would also swap `clear_log_messages` and `close_temp_logs` to be sure no
 messages are sent to the callback function in between those calls (which
 would then reallocated the messages smartlist, leading to another memory
 leak). It is unlikely to happen but it is better to be correct now than
 later IMO.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17076#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online