[tor-bugs] #18029 [Tor]: ADD_ONION doesn't validate its target

[Tor Bug Tracker & Wiki]

#18029: ADD_ONION doesn't validate its target
-----------------------------+------------------------------------
 Reporter:  atagar           |          Owner:
     Type:  defect           |         Status:  needs_information
 Priority:  Low              |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor              |        Version:  Tor: 0.2.7.1-alpha
 Severity:  Minor            |     Resolution:
 Keywords:  tor-hs tor-core  |  Actual Points:
Parent ID:                   |         Points:
  Sponsor:                   |
-----------------------------+------------------------------------
Changes (by yawning):

 * cc: yawning (added)
 * status:  new => needs_information
 * version:   => Tor: 0.2.7.1-alpha
 * keywords:   => tor-hs tor-core
 * milestone:   => Tor: 0.2.8.x-final


Comment:

 As far as I know the code does validate (See:
 rendservice.c:rend_service_parse_port_config()).

 I've tried master, 0.2.7.6 (Arch package), and 0.2.7.3-dev (what I
 happened to have on my craptop), and they all reject the command in the
 bug report with a `512 Invalid VIRTPORT/TARGET`.

 {{{
 >>> GETINFO version
 250-version=0.2.8.0-alpha-dev (git-8fc27ac0420c7120)
 250 OK

 >>> ADD_ONION NEW:BEST Port=4567,not_an_address:4567
 512 Invalid VIRTPORT/TARGET
 }}}

 Do you have any local changes that may be causing the validation to break?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18029#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online