[tor-bugs] #17921 [Tor]: OPENSSL_V_SERIES(1, 1, 0) compat guard macro borks LibreSSL

[Tor Bug Tracker & Wiki]

#17921: OPENSSL_V_SERIES(1,1,0) compat guard macro borks LibreSSL
------------------------------+------------------------------------
 Reporter:  cypherpunks       |          Owner:  nickm
     Type:  defect            |         Status:  reopened
 Priority:  Medium            |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor               |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:  libressl openssl  |  Actual Points:
Parent ID:                    |         Points:
  Sponsor:                    |
------------------------------+------------------------------------
Changes (by cypherpunks-duplicate):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 It works for the general building-of-tor sense, but it doesn't cover such
 as the code guarded in tortls.c and test_tortls.c, such as:

 src/test/test_tortls.c:1350:21: error: unused variable 'rbuf_b'
       [-Werror,-Wunused-variable]
   size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1;
                     ^
 src/test/test_tortls.c:1350:43: error: unused variable 'wbuf_b'
       [-Werror,-Wunused-variable]
   size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1;
                                           ^
 src/test/test_tortls.c:1350:10: error: unused variable 'rbuf_c'
       [-Werror,-Wunused-variable]
   size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1;
          ^
 src/test/test_tortls.c:1350:32: error: unused variable 'wbuf_c'
       [-Werror,-Wunused-variable]
   size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1;
                                ^
 4 errors generated.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17921#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online