[tor-bugs] #17840 [Tor]: Add a minimal implementation of ClientUseIPv4 so IPv6-only clients can bootstrap

[Tor Bug Tracker & Wiki]

#17840: Add a minimal implementation of ClientUseIPv4 so IPv6-only clients can
bootstrap
--------------------+------------------------------------
 Reporter:  teor    |          Owner:  teor
     Type:  defect  |         Status:  needs_revision
 Priority:  Medium  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor     |        Version:
 Severity:  Normal  |     Resolution:
 Keywords:  ipv6    |  Actual Points:
Parent ID:  #17811  |         Points:
  Sponsor:          |
--------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Returning to 4d453a7a9041 Choose directory servers by IPv4/IPv6
 preferences
  * directory_initiate_command_routerstatus_rend() -- it seems like the new
 code here might be better to extract into a new function?
  * Can it ever be right to use the directory_initiate_command() interface
 any more, since it doesn't know about IPv6/IPv4 issues?
  * We used to have a notion of "anonymized connection not using begindir"
 -- we went to a  node and told it to make a connection to its own dirport.
 Did we rip out all vestiges of this?  If not, the code here is a bit
 sketchy.

 Returning to 5ffe801801da Use fascist firewall and ClientUseIPv4 for
 bridge clients
  * This whole thing is a bit scary.
  * In the autobool conversion, did you grep for ClientUseIPv4 and
 ClientUseIPv6 to make sure you found them all?
  * In lieu of the majority of this patch, maybe it would be better to have
 the torrc's ClientUseIPv[46] options set or_options_t's
 ClientUseIPv[46]_option fields, and then have options_validate() or
 something set ClientUseIPv[46] based on that? Not sure.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17840#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online