[tor-bugs] #17983 [Tor]: Build tor with -fwrapv by default

[Tor Bug Tracker & Wiki]

#17983: Build tor with -fwrapv by default
-------------------------+------------------------------------
 Reporter:  teor         |          Owner:
     Type:  enhancement  |         Status:  new
 Priority:  Medium       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:9 nickm]:
 > I have no strong preference between gcc-hardening or default. What do
 you think?

 I think --enable-gcc-hardening, because then -ftrapv on by default, but
 can be disabled with --disable-gcc-hardening if needed.

 This is the simplest change, too: just replace the -fwrapv in --enable-
 gcc-hardening with -ftrapv. (And it avoids confusion between some builds
 having an implicit -fwrapv, and others having an implicit -ftrapv.)

 We should let the TBB people (mikeperry?) know when we do this, because in
 their hardened series TBB uses -fwrapv.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17983#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online