[tor-bugs] #17983 [Tor]: Build tor with -fwrapv by default

[Tor Bug Tracker & Wiki]

#17983: Build tor with -fwrapv by default
-------------------------+------------------------------------
 Reporter:  teor         |          Owner:
     Type:  enhancement  |         Status:  new
 Priority:  Medium       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:4 nickm]:
 > Hm.  With all this, -fwrapv is starting to sound pretty reasonable.

 Yes. And we can still check for overflows in the code when we need to.

 > We should also treat any unmarked sign integer overflow as a bug,
 though, IMO.

 I agree - signed integer overflows often lead to unexpected behaviour.
 (They can be detected using -ftrapv.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17983#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online