[tor-bugs] #18392 [Tor]: windows build failures

[Tor Bug Tracker & Wiki]

#18392: windows build failures
--------------------+------------------------------------
 Reporter:  weasel  |          Owner:
     Type:  defect  |         Status:  new
 Priority:  Medium  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor     |        Version:  Tor: unspecified
 Severity:  Normal  |     Resolution:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
  Sponsor:          |
--------------------+------------------------------------

Comment (by weasel):

 I have bisected this on our windows build host, and it seems that the
 following commit is the one first showing this:
 {{{
 $ git bisect bad
 f48c607fd970aedaf0180a0a23b04eb5101abca0 is the first bad commit
 commit f48c607fd970aedaf0180a0a23b04eb5101abca0
 Author: Jeremy <jeremy at sturgix.com>
 Date:   Tue Dec 8 13:25:15 2015 -0500

     Harden check_private_dir() to remove any potential race.

     Remove any potential race between stat() and chmod().
     Replace stat() with fstat().
     Replace chmod() with fchmod()

 :040000 040000 7cc8d63139975a0e5beb13347c2afc8282cd2d4e
 3da2265493282643f73060aaa7677ac467cf5d84 M      src


 }}}

 (Note that I built with -DO_NOFOLLOW=0 to work around the build issue
 fixed in 1e99508)

 The previous one, 4e19133 builds and tests fine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18392#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online