[tor-bugs] #14821 [Tor]: --enable-expensive-hardening broken with clang

[Tor Bug Tracker & Wiki]

#14821: --enable-expensive-hardening broken with clang
--------------------------+------------------------------------
 Reporter:  Sebastian     |          Owner:
     Type:  defect        |         Status:  assigned
 Priority:  High          |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor           |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  027-backport  |  Actual Points:
Parent ID:                |         Points:
  Sponsor:                |
--------------------------+------------------------------------
Changes (by nickm):

 * keywords:  027-triaged-1-out => 027-backport


Comment:

 ug, apparently clang 3.7 broke everybody by messing up autotools builds,
 so that clang only builds its sanitizers correctly with cmake.  So first I
 had to fix that on my desktop.

 Then I managed to figure out that the only compilation problems were
 related to strcmp() and to some parenthesis in test_util.

 And then I realized that it's going to complain a lot about leaks in the
 tests unless I say ASAN_OPTIONS=detect_leaks=0 .

 And I found a couple of actual bugs with the tests, so I'm going to open
 tickets for those.  But for now, the branch `bug14821` could be what we
 need here.  The part of this not applying to test_util.c could be an 0.2.7
 backport but I'm a bit nervous.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14821#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online