[tor-bugs] #18348 [Tor]: Tor conflates IPv4 Dir port with IPv6 OR Port

[Tor Bug Tracker & Wiki]

#18348: Tor conflates IPv4 Dir port with IPv6 OR Port
-----------------------+------------------------------------
 Reporter:  sysrqb     |          Owner:
     Type:  defect     |         Status:  new
 Priority:  Very High  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor        |        Version:  Tor: unspecified
 Severity:  Major      |     Resolution:
 Keywords:             |  Actual Points:
Parent ID:             |         Points:
  Sponsor:             |
-----------------------+------------------------------------

Comment (by sysrqb):

 It looks like this should do it - I'm testing it now:
 {{{
 diff --git a/src/or/policies.c b/src/or/policies.c
 index 179230b..5b3405b 100644
 --- a/src/or/policies.c
 +++ b/src/or/policies.c
 @@ -413,6 +413,11 @@ fascist_firewall_allows_address(const tor_addr_t
 *addr,
      if (tor_addr_family(addr) == AF_INET6 &&
          (!fascist_firewall_use_ipv6(options) || (pref_only &&
 !pref_ipv6)))
        return 0;
 +  } else {
 +    if (tor_addr_family(addr) == AF_INET)
 +      return 1;
 +    return 0;
    }

    return addr_policy_permits_tor_addr(addr, port,
 }}}

 Based on the comment for fascist_firewall_allows_address(), this was the
 intended functionality but I don't see where this happens:
 {{{
  * If we are configured as a server, ignore any address family preference
 and
  * just use IPv4.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18348#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online