[tor-bugs] #16825 [Tor]: client with explicit EntryNodes, no cached-* files never finds its entrynodes

[Tor Bug Tracker & Wiki]

#16825: client with explicit EntryNodes, no cached-* files never finds its
entrynodes
--------------------------------+------------------------------------
 Reporter:  starlight           |          Owner:
     Type:  defect              |         Status:  new
 Priority:  Medium              |      Milestone:  Tor: 0.2.9.x-final
Component:  Tor                 |        Version:  Tor: 0.2.6.10
 Severity:  Normal              |     Resolution:
 Keywords:  guards, 028-triage  |  Actual Points:
Parent ID:                      |         Points:  medium
  Sponsor:  SponsorU            |
--------------------------------+------------------------------------

Comment (by arma):

 Context: Once upon a time, directory_info_has_arrived() was the spider in
 the middle of the directory fetching web: every time we made any progress
 at bootstrapping, we could call this function, and it would evaluate the
 situation, learn what new stuff just came in, and dispatch the next step
 in response.

 I was going to say:
 {{{Over time, this functionality got spread throughout the source code, so
 when we had a guess about what step ought to happen next, we called it
 directly. We still also called directory_info_has_arrived() most of the
 time, but it lost the central dispatch role that it once had.}}} but upon
 looking in more detail, I think we didn't actually decentralize it that
 much.

 Then I was going to say {{{It looks like router_dir_info_changed() is
 playing a lot of the role that the directory_info_has_arrived dispatcher
 used to play.}}} but upon looking in more detail, its primary role is just
 to force us to re-evaluate whether we have enough dir info, next time we
 ask.

 So I'm going to stop working on the new ticket I was going to open,
 entitled {{{Use directory_info_has_arrived() consistently, or get rid of
 it}}}, and suggest that we should plan to use directory_info_has_arrived
 more consistently.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16825#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online