[tor-bugs] #16728 [Tor Browser]: Test cases for favicon isolation

[Tor Bug Tracker & Wiki]

#16728: Test cases for favicon isolation
------------------------------------------------+--------------------------
 Reporter:  mikeperry                           |          Owner:  boklm
     Type:  enhancement                         |         Status:
 Priority:  Medium                              |  needs_revision
Component:  Tor Browser                         |      Milestone:
 Severity:  Normal                              |        Version:
 Keywords:  tbb-testcase, TorBrowserTeam201602  |     Resolution:
Parent ID:                                      |  Actual Points:
  Sponsor:                                      |         Points:
------------------------------------------------+--------------------------

Comment (by arthuredelstein):

 Replying to [comment:3 gk]:
 > Looks good. Just some nits: There are at least two comments that need to
 get updated including the favicon test as well (line 7/8 and line 107 in
 `browser_cacheFirstParty.js`). While you are trying to get rid of
 superfluous whitespaces, at the end of line 113 in
 `browser_cacheFirstParty.js` is another one.

 Thanks for the review. Here's a revised version with the changes you
 suggested.

 ​https://github.com/arthuredelstein/tor-browser/commit/16728+1

 For the record, I tried reverting our favicon patch (#13670.1) and this
 patch correctly detected the failure to isolate the favicons by URL bar
 domain.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16728#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online