[tor-bugs] #18330 [Tor Launcher]: Tor Launcher only accepts HEXDIGIT passwords for controller

[Tor Bug Tracker & Wiki]

#18330: Tor Launcher only accepts HEXDIGIT passwords for controller
--------------------------+-----------------------
 Reporter:  gk            |          Owner:  brade
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Tor Launcher  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
  Sponsor:                |
--------------------------+-----------------------

Comment (by cypherpunks):

 Replying to [comment:3 gk]:
 > Replying to [comment:1 cypherpunks]:
 > > Why is quoting the password a good thing? What's the trouble with
 quoting correctly?
 >
 > Well, as soon as you need to escape your quoting character because you
 use it in your password it gets messy easily. And what I did say, was that
 it's a good thing to give the user a hint about correctly quoting the
 password. Not that the need for quoting on the user side is a good thing.
 Right. It is good to mention the issue (like in a comment or a manual
 page), for people writing env vars yet not familiar with the shell (?).

 > In fact, I think we should abstract that away from the user. They should
 just be able to enter their password and Tor Launcher should take care of
 the proper quoting if needed.
 I agree with this. The env var should just be the-password-itself, nothing
 more.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18330#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online