[tor-bugs] #17443 [Tor]: tor-gencert --passphrase-fd improperly checks for newline

[Tor Bug Tracker & Wiki]

#17443: tor-gencert --passphrase-fd improperly checks for newline
------------------------+------------------------------------
 Reporter:  junglefowl  |          Owner:
     Type:  defect      |         Status:  needs_review
 Priority:  Medium      |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor         |        Version:  Tor: 0.2.7.4-rc
 Severity:  Normal      |     Resolution:
 Keywords:  crash       |  Actual Points:
Parent ID:              |         Points:
  Sponsor:              |
------------------------+------------------------------------
Changes (by teor):

 * keywords:  security 027-backport 026-backport => crash


Comment:

 Oops, forgot to account for the source of the input data. It's not
 security, just a crash.

 Looks good, but (and this may be a different ticket), what if we're
 running tor-gencert on Windows? If we strip off the '\n', do we get the
 '\r' as well?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17443#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online