[tor-bugs] #17949 [Tor]: Make loopback address search more accurate

[Tor Bug Tracker & Wiki]

#17949: Make loopback address search more accurate
------------------------------------+------------------------------------
 Reporter:  teor                    |          Owner:  rl1987
     Type:  enhancement             |         Status:  needs_revision
 Priority:  Medium                  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                     |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  easy TorCoreTeam201602  |  Actual Points:
Parent ID:  #17991                  |         Points:  medium
  Sponsor:                          |
------------------------------------+------------------------------------

Comment (by teor):

 (This is my second comment in a row.)

 Replying to [comment:17 nickm]:
 > Hm. This makes a big pile of changes throughout the code, and adds an
 extra flag argument to get_interface_address6_list, which all callers must
 get right.

 Why don't we call the new behaviour get_loopback_address6_list, and keep
 get_interface_address6_list for the old behaviour?

 They can be implemented using get_interface_address6_list_impl, with the
 extra argument. Then we only have to get it right in two places.

 And I can't see any reason that we'd want to get loopback and other
 addresses in the same list. We typically either want one or the other.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17949#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online