[tor-bugs] #8786 [Tor]: Add extra-info line that tracks the number of consensus downloads of each pluggable transports

[Tor Bug Tracker & Wiki]

#8786: Add extra-info line that tracks the number of consensus downloads of each
pluggable transports
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  Low                                  |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  pt, tor-bridge, flashproxy,          |        Version:
  026-triaged-1, 026-deferrable,                 |     Resolution:
  027-triaged-1-out                              |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------
Changes (by asn):

 * cc: athena (added)


Comment:

 Replying to [comment:14 karsten]:
 > There, I implemented my idea above and gave it some testing using
 Chutney.  Not sure if it's the most elegant approach, but I think it
 works.  See the updated branch
 [https://gitweb.torproject.org/karsten/tor.git/log/?h=task-8786 here].
 >
 > asn, mind reviewing the change and giving this branch another chance on
 your bridge, ideally with `PublishServerDescriptor 0` being set and you
 and I meeting in #tor-dev 24.000000000 hours later?

 Patch looks like it could work. I'm now running it on my bridge.

 Ideally we would want to functionify all the extra code and put it on a
 separate function, to not pollute `directory_handle_command_get()`
 further.

 Also, I'm still wondering if there is an O(1) way to get from
 `dir_connection_t` to `channel_t` by following links (maybe through
 `connection_t`). Because the current approach is O(n) where n is the
 number of open circuits. Not sure if this is premature optimization or
 not. Nick or Andrea would know.

 Will get back to you tomorrow about the results.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8786#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online