[tor-bugs] #18144 [Tor Browser]: about:tor update arrow position is wrong (Retina and zoom)

[Tor Bug Tracker & Wiki]

#18144: about:tor update arrow position is wrong (Retina and zoom)
-----------------------------------+-----------------------------------
 Reporter:  mcs                    |          Owner:  tbb-team
     Type:  defect                 |         Status:  needs_information
 Priority:  Medium                 |      Milestone:
Component:  Tor Browser            |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam201602R  |  Actual Points:
Parent ID:                         |         Points:
  Sponsor:                         |
-----------------------------------+-----------------------------------
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 Looking at the diff between the first and the second patch and at the
 comment that changed I am wondering why
 {{{
 tbXpos *= window.devicePixelRatio;
 }}}
 slipped in. I mean if `window.devicePixelRatio` is alaways `1.0` for non-
 Chrome windows (causing the bug we have here) why do we need to multiply
 `tbXpos` with it in the first place? What am I missing?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18144#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online