[tor-bugs] #18051 [Tor]: directory_send_command should decorate IPv6 addresses to avoid port ambiguity

[Tor Bug Tracker & Wiki]

#18051: directory_send_command should decorate IPv6 addresses to avoid port
ambiguity
-------------------------------+------------------------------------
 Reporter:  teor               |          Owner:  malekbr
     Type:  defect             |         Status:  needs_review
 Priority:  High               |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ipv6, easy, intro  |  Actual Points:
Parent ID:  #17811             |         Points:  small
  Sponsor:                     |
-------------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:6 malekbr]:
 > Repo : https://github.com/malekbr/tor
 > Branch : decorated_ipv6_directory_send_command
 >
 > Was not tested, just made sure it doesn't break and runs.

 Thanks for this patch, it looks good.

 I noticed some other things we might want to fix eventually, see #18276.

 Testing this needs an IPv6 tor client (#17840) connecting to an IPv6 tor
 directory server through an IPv6-aware/IPv6-transparent proxy.

 I've checked that it doesn't break the IPv6 bootstrap code in #17840 on an
 IPv6-only system, with and without bridges. On this basis, I'd be happy to
 see it merged.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18051#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online