[tor-bugs] #18258 [Tor]: Code cleanup, aes.c/crypto.c

[Tor Bug Tracker & Wiki]

#18258: Code cleanup, aes.c/crypto.c
-------------------------+------------------------------------
 Reporter:  malekbr      |          Owner:
     Type:  enhancement  |         Status:  needs_revision
 Priority:  Very Low     |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:
 Severity:  Trivial      |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 {{{
 -  if (fast_memneq(output, encrypt_zero, 16)) {
 -    /* Counter mode is buggy */
 -    log_notice(LD_CRYPTO, "This OpenSSL has a buggy version of counter
 mode; "
 -               "not using it.");
 -  } else {
 -    /* Counter mode is okay */
 -    log_info(LD_CRYPTO, "This OpenSSL has a good implementation of
 counter "
 -               "mode; using it.");
 -    should_use_openssl_CTR = 1;
 -  }
 }}}

 It might be cool to keep the check code, and instead of giving a
 log_notice() in the bug case, give a log_err() and exit.

 Also, does anything still use aes_cnt_cipher.buf and aes_fill_buffer?  If
 not, can we throw them out?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18258#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online