[tor-bugs] #18248 [Tor]: tor logging twice when --+Log argument and config are used

[Tor Bug Tracker & Wiki]

#18248: tor logging twice when --+Log argument and config are used
------------------------+--------------------------------
     Reporter:  reezer  |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:
    Component:  Tor     |    Version:  Tor: 0.2.8.1-alpha
     Severity:  Normal  |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+--------------------------------
 When specifying the Log option to the same place twice various messages
 will be logged twice.

 Specifying
 {{{
 # On the command line:
 --+Log notice file /var/log/tor

 # In torrc:
 Log notice file /var/log/tor
 }}}


 will result in messages like those:


 {{{
 Feb 05 11:05:41.000 [notice] Bootstrapped 0%: Starting
 Feb 05 11:05:41.000 [notice] Bootstrapped 0%: Starting
 Feb 05 11:05:54.000 [notice] Bootstrapped 80%: Connecting to the Tor
 network
 Feb 05 11:05:54.000 [notice] Bootstrapped 80%: Connecting to the Tor
 network
 Feb 05 11:05:54.000 [notice] Bootstrapped 85%: Finishing handshake with
 first hop
 Feb 05 11:05:54.000 [notice] Bootstrapped 85%: Finishing handshake with
 first hop
 Feb 05 11:05:54.000 [notice] Self-testing indicates your ORPort is
 reachable from the outside. Excellent.
 Feb 05 11:05:54.000 [notice] Self-testing indicates your ORPort is
 reachable from the outside. Excellent.
 }}}

 In a way one could say that's expected, but I think equivalent options
 should maybe be deduplicated.

 This occurs on: Tor v0.2.8.1-alpha (git-9093e3769746742f) running on
 FreeBSD with Libevent 2.0.22-stable, OpenSSL 1.0.2f and Zlib 1.2.8.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18248>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online