[tor-bugs] #18240 [Tor]: 'make test-stem' yields No rule to make target '"./src/or/tor"'

[Tor Bug Tracker & Wiki]

#18240: 'make test-stem' yields No rule to make target '"./src/or/tor"'
--------------------+------------------------------------
 Reporter:  arma    |          Owner:
     Type:  defect  |         Status:  new
 Priority:  Medium  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor     |        Version:
 Severity:  Normal  |     Resolution:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
  Sponsor:          |
--------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [comment:3 cypherpunks]:
 > I didn't look very hard but it seems like the only 2 instances come from
 the following commit:
 https://gitweb.torproject.org/tor.git/commit/?id=670affa792e7613f6e6b5d960805418359ac0ec7
 >
 > where some fellow cpunk apparently got m4/make/shell messed up in his
 head, and then nickm not testing what he applies. But hey it's an alpha,
 right? ...
 This commit was added for #17818. The quotation of the make variables is
 indeed a mistake. Using `git grep "=\"" "*.am"` only turned up instances
 of shell snippets within make rules except for those 2 instances. I
 propose the following patch
 {{{
 diff --git a/Makefile.am b/Makefile.am
 index fc9f7b2..62f7ef5 100644
 --- a/Makefile.am
 +++ b/Makefile.am
 @@ -23,9 +23,9 @@ AM_CFLAGS = @TOR_SYSTEMD_CFLAGS@
  SHELL = @SHELL@

  if COVERAGE_ENABLED
 -TESTING_TOR_BINARY="$(top_builddir)/src/or/tor-cov"
 +TESTING_TOR_BINARY=src/or/tor-cov$(EXEEXT)
  else
 -TESTING_TOR_BINARY="$(top_builddir)/src/or/tor"
 +TESTING_TOR_BINARY=src/or/tor$(EXEEXT)
  endif

  include src/include.am
 }}}
 The `top_builddir` variable is not necessary because Tor only has one
 Makefile and according to the Autoconf documentation this variable is
 equal to `builddir` (which is always ".") in the top-level directory of
 the build tree.
 Furthermore, the Automake variable `EXEEXT` automatically contains the
 appropriate executable extension for the platform. It is used internally
 by Automake to create its rules so in order to call the correct rule we
 have to add it too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18240#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online