[tor-bugs] #7478 [Tor]: Allow routersets to include/exclude nodes by IPv6 address

[Tor Bug Tracker & Wiki]

#7478: Allow routersets to include/exclude nodes by IPv6 address
-----------------------------------------------+---------------------------
 Reporter:  nickm                              |          Owner:  teor
     Type:  enhancement                        |         Status:
 Priority:  High                               |  needs_review
Component:  Tor                                |      Milestone:  Tor:
 Severity:  Normal                             |  0.2.8.x-final
 Keywords:  tor-client ipv6 TorCoreTeam201602  |        Version:
Parent ID:                                     |     Resolution:
  Sponsor:                                     |  Actual Points:
                                               |         Points:  small
-----------------------------------------------+---------------------------

Comment (by teor):

 Replying to [comment:20 bugzilla]:
 > Review:
 > src/or/routerset.c
 > > @@ -275,10 +280,14 @@ routerset_contains_router(const routerset_t
 *set, const routerinfo_t *ri,
 >
 > > @@ -292,10 +301,14 @@ routerset_contains_routerstatus(const
 routerset_t *set,
 >
 > Transform {{{addr}}} to const pointer (as {{{ipv6_addr}}}) or vice versa
 for uniformity.

 We can't make this change to the patch, because addr requires locally
 allocated storage, but ipv6_addr does not.

 > src/test/test_routerset.c
 > > @1111: int
 > Avoid {{{int}}} and other non-fixed-width data types.

 This change may cause compiler warnings on some platforms due to casting
 the int return value to the fixed-width variable. The width of int is
 irrelevant when it's used as a boolean.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7478#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online