[tor-bugs] #17975 [Core Tor/Tor]: Introduce OutboundExitAddress to enable exit-only traffic to go via a different IP address

[Tor Bug Tracker & Wiki]

#17975: Introduce OutboundExitAddress to enable exit-only traffic to go via a
different IP address
-------------------------------------------------+-------------------------
 Reporter:  naif                                 |          Owner:
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  lorax, yawning, isaremoved review-   |  Actual Points:
  group-13                                       |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Good progress.  I like the array usage. Some more comments:

   * Reserving the symbols "EXIT, OR, EXIT_AND_OR, OUTBOUND_MAX" globally
 seems problematic. They should probably get a prefix.
   * AF_MAX can be pretty big on some systems, but we're only using two
 address families here.  That seems kind of wasteful.
   * The memset of " sizeof(tor_addr_t)*OUTBOUND_MAX*AF_MAX" seems fragile.
 Probably better to use "sizeof(options->OutboundBindAddresses)" instead so
 that it can't get out-of-sync with the actual array bounds.
   * The function names "verify_and_store_address" and
 "parse_address_lines" should probably make it clear that they are for
 outbound*address lines.  Otherwise, it gets confusing.

 Teor, any other notes here?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17975#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online