[tor-bugs] #20307 [Core Tor/Tor]: [warn] Remote server sent bogus reason code 65021

[Tor Bug Tracker & Wiki]

#20307: [warn] Remote server sent bogus reason code 65021
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  circuit, 029-backport, nickm-        |  Actual Points:
  deferred-20161017, triage-out-030-201612       |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 Replying to [comment:10 nickm]:
 > I think you want this to be in needs_review with branch
 `bug20307_030_01`?  Or is that not ready?

 It is, thanks! I somehow failed to do so.
 >
 > Should we make a similar change anywhere else? (like, on connections or
 channels or something?)

 I can only see `end_reason` (when searching for "reason") in an
 `edge_connection_t` that is a `uint16_t` but that seems we only assign
 `END_STREAM_*` reasons which none of them are negative so should be fine.
 We might want to be careful overtime with this because as far as I can
 tell, the end circuit reason is 1 byte in the payload of a DESTROY cell
 which is not even a uint16_t.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20307#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online