[tor-bugs] #20458 [Core Tor/Tor]: Integration tests should be run locally before committing code changes

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Dec 22 09:39:31 UTC 2016


#20458: Integration tests should be run locally before committing code changes
----------------------------------------------+----------------------------
 Reporter:  chelseakomlo                      |          Owner:
                                              |  chelseakomlo
     Type:  enhancement                       |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.1.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  test, doc, triage-out-030-201612  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:  teor                              |        Sponsor:
----------------------------------------------+----------------------------

Comment (by cypherpunks):

 Replying to [comment:22 chelseakomlo]:
 > Thanks for the feedback- see
 `git at github.com:chelseakomlo/tor_patches.git`, branch
 `documentation_integ_tests` with these changes.

 The changes look good. I'll leave it to teor for the final review.

 In the future create a new branch when you change the history of commits
 that are already made public (aka pushed). See the warning in the
 [https://help.github.com/articles/changing-a-commit-message/#amending-
 older-or-multiple-commit-messages Github article] about changing messages
 of pushed commits. The solution is to use `git checkout -b new-branch-
 name` to create and checkout a new branch before rewriting history.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20458#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list