[tor-bugs] #20596 [Metrics]: streamline build.xml and metrics_checkstyle.xml throughout all java projects

[Tor Bug Tracker & Wiki]

#20596: streamline build.xml and metrics_checkstyle.xml throughout all java
projects
-------------------------+--------------------------
 Reporter:  iwakeh       |          Owner:  iwakeh
     Type:  enhancement  |         Status:  assigned
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+--------------------------

Comment (by karsten):

 Replying to [comment:16 iwakeh]:
 > I'd propose having another git repository `metrics-base` or `metrics-
 java-base` for providing the standard build elements, which currently
 would be a base-build.xml and metrics' checkstyle rules.
 > This can be referenced as a sub-module and thus avoid code duplication.

 Plausible!

 > Thoughts?

 First thought is that we should try to avoid confusing new contributors.
 Basically, we're adding yet another hurdle for them to get up to speed.
 Though I admit that this hurdle is worth considering to avoid duplicating
 code.

 What we'd have to do is fail with a useful error message in case this
 submodule has not yet been initialized.  That message should contain the
 exact command that is necessary to initialize the missing submodule.
 Wording is important here, I think.

 Another thought is that we should make sure that this won't break any
 future Jenkins tasks.  I believe initializing a Git submodule from the
 same repository is okay, but we should check.  Copying hiro on this ticket
 for that reason.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20596#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online