[tor-bugs] #20988 [Core Tor/Tor]: Test fgets_eagain fails on FreeBSD-amd64

[Tor Bug Tracker & Wiki]

#20988: Test fgets_eagain fails on FreeBSD-amd64
------------------------------+-----------------
     Reporter:  cypherpunks   |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-----------------
 According to the [https://buildbot.pixelminers.net/builders BSD Buildbot]
 {{{
 util/fgets_eagain:
   FAIL src/test/test_util.c:3952: assert(retptr OP_EQ buf): 0x0 vs
 0x7fffffffe944
   [fgets_eagain FAILED]
 }}}

 This means that fgets returns a null pointer on partial lines instead of
 the buffer as expected.

 Previously this test was passing but started failing with
 [https://buildbot.pixelminers.net/builders/FreeBSD-amd64/builds/105 build
 #105]. Looking at the changes to libc it looks like this is caused by
 [https://svnweb.freebsd.org/base/head/lib/libc/stdio/fgets.c?r1=305413&r2=305412&pathrev=305413
 revision 305413] (which was added earlier in the same month the test
 started failing).

 I'm unsure whether FreeBSD is right and other libc implementations are
 wrong or the other way around.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20988>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online