[tor-bugs] #20824 [Core Tor/Tor]: [prop271, controller] DROPGUARDS support for new guard backend

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Dec 14 13:47:18 UTC 2016


#20824: [prop271, controller] DROPGUARDS support for new guard backend
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-guard regression                 |  Actual Points:  .1
  TorCoreTeam201612                              |
Parent ID:  #20822                               |         Points:  .5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by chelseakomlo):

 Overall looks good, and tests pass!

 One question: It looks like we have this case in
 remove_all_entry_guards_for_guard_selection:

 {{{
 #ifdef ENABLE_LEGACY_GUARD_ALGORITHM
   SMARTLIST_FOREACH(gs->chosen_entry_guards, entry_guard_t *, entry, {
     control_event_guard(entry->nickname, entry->identity, "DROPPED");
   });
 #endif
   SMARTLIST_FOREACH(gs->sampled_entry_guards, entry_guard_t *, entry, {
     control_event_guard(entry->nickname, entry->identity, "DROPPED");
   });
 }}}

 Just to confirm: if we are running the legacy algorithm, a guard_selection
 will use both chosen_entry_guards as well as sampled_entry_guards?

 Finally, it may be helpful to add a unit test for this, as we add (some)
 new functionality to remove_all_entry_guards_for_guard_selection with
 guard context.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20824#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list