[tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
---------------------------------+------------------------------------
 Reporter:  yawning              |          Owner:  yawning
     Type:  enhancement          |         Status:  new
 Priority:  Medium               |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor         |        Version:  Tor: 0.2.8.4-rc
 Severity:  Normal               |     Resolution:
 Keywords:  tor-core tor-crypto  |  Actual Points:
Parent ID:                       |         Points:  3
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------

Comment (by nickm):

 These functions are replaced by no-ops in OpenSSL 1.1:
 {{{
 CRYPTO_cleanup_all_ex_data
 ENGINE_cleanup
 ERR_free_strings
 EVP_cleanup
 }}}

 These are replaced with variants of `OPENSSL_init_crypto()`:
 {{{
 ERR_load_crypto_strings
 OpenSSL_add_all_algorithms
 }}}

 These are replaced with variants of `OPENSSL_init_ssl()`:
 {{{
 SSL_library_init
 SSL_load_error_strings
 }}}

 These have new names:
 `EVP_CIPHER_CTX_cleanup()` becomes `EVP_CIPHER_CTX_reset()`.
 `X509_get_notAfter()` becomes `X509_get0_notAfter` or
 `X509_getm_notAfter`.
 `X509_get_notBefore()` becomes `X509_get0_notBefore` or
 `X509_getm_notBefore`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19429#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online