[tor-bugs] #20147 [Applications/Tor Browser]: [PATCH] (re-)dzip.sh: various improvements

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Dec 9 21:00:47 UTC 2016


#20147: [PATCH] (re-)dzip.sh: various improvements
--------------------------------------+--------------------------------
 Reporter:  rustybird                 |          Owner:  tbb-team
     Type:  enhancement               |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-gitian                |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by rustybird):

 What a nightmare! It's making me ill that this has turned into such a time
 sink for you, so sorry. I've found some instructions for (kind of) getting
 Gitian to work on Qubes in a Bitcoin context, maybe I can adapt these to
 Tor Browser and really test my shit in the future:
 https://groups.google.com/d/msg/qubes-users/tnJnjlZgpGs/0bGDaHwiAgAJ

 Anyway, this seems to have uncovered a legit (though benign) bug in
 `windows/gitian-firefox.yml`: I've extracted `torbrowser-install-6.0.7_en-
 US.exe` and, in contrast to Linux and Mac, there simply is no
 `Browser/webapprt/omni.ja` on Windows. So that line could be deleted?

 (If you look through a successful Windows build log, it will probably show
 how the old `re-dzip.sh` ignored the `unzip`, `zip`, and `mv` failures and
 exited "successfully", because the last thing it did was remove the
 temporary directory.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20147#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list