[tor-bugs] #20572 [Core Tor/Tor]: hs: Remove the private key material from hs_descriptor.h

[Tor Bug Tracker & Wiki]

#20572: hs: Remove the private key material from hs_descriptor.h
------------------------------------------------+--------------------------
 Reporter:  dgoulet                             |          Owner:  jryans
     Type:  defect                              |         Status:
                                                |  needs_revision
 Priority:  High                                |      Milestone:  Tor:
                                                |  0.3.0.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tor-hs, prop224, TorCoreTeam201612  |  Actual Points:
Parent ID:                                      |         Points:  0.5
 Reviewer:                                      |        Sponsor:
                                                |  SponsorR-must
------------------------------------------------+--------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Comments:

 1. We only use a changes file if the patch is a feature or actually fixing
 something that has been released. In this case, we don't need one. I'm not
 sure if we documented that somewhere but at least here it is :).

 2. I see some extra changes that have nothing to do with the commit:

 {{{
 -                    &encoded_cert) < 0) {
 +                                &encoded_cert) < 0) {
 }}}

  or

 {{{
 +  version = desc->plaintext_data.version;
 +  if (!hs_desc_is_supported_version(version)) {
 }}}

  It's good stuff! and fine for now but next time, simply put them in
 different commit which would be great!

 So basically, if you can resubmit an extra fixup commit in the branch to
 remove the change file it would be great and ready to go! (git commit
 --fixup=). THANKS!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20572#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online