[tor-bugs] #20906 [Core Tor/Tor]: SocksPorts and ControlPorts should be stored in a set, not a list

[Tor Bug Tracker & Wiki]

#20906: SocksPorts and ControlPorts should be stored in a set, not a list
-----------------------------+------------------------------------
 Reporter:  arthuredelstein  |          Owner:
     Type:  defect           |         Status:  new
 Priority:  High             |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tbb-wants        |  Actual Points:
Parent ID:                   |         Points:  0.2
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------

Comment (by mcs):

 Replying to [comment:6 dgoulet]:
 > As I understand it, it's a blocker for TBB to have this awesome
 important security feature to let's fix it asap.

 Thanks! I want to clarify that even after this ticket is fixed, it will
 still be tricky for Tor Browser/Tor Launcher to cleanly switch between
 Unix domain port listeners and TCP listeners. Why? Because any SocksPort
 and ControlPort config that is passed on the tor command line is written
 to torrc after a SAVECONF command, and because the we cannot Tor Browser's
 hardcode the Unix domain socket paths we cannot avoid passing via the
 command line.

 Is the tor team open to the idea that config that is passed via the
 command line should not be written to torrc? Or at least are you open to
 providing a way to specify that config is ephemeral and should not be
 persisted to torrc? We could introduce a new prefix character to indicate
 that, e.g., dot as in `.+SocksPort unix:PATH` or similar. If this is
 something the network team would be willing to consider, I will open a new
 ticket. I am not trying to sign anyone else up for this work; it might
 even be something for which the browser team could contribute patches.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20906#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online