[tor-bugs] #20147 [Applications/Tor Browser]: [PATCH] (re-)dzip.sh: various improvements

[Tor Bug Tracker & Wiki]

#20147: [PATCH] (re-)dzip.sh: various improvements
--------------------------------------+--------------------------------
 Reporter:  rustybird                 |          Owner:  tbb-team
     Type:  enhancement               |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-gitian                |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by rustybird):

 Damn, I'm very sorry for breaking the build! Apparently, `unzip(1)` has
 some really weird exit statuses:

 {{{
 0      normal; no errors or warnings detected.

 1      one or more warning errors were encountered, but process-
        ing completed successfully anyway. [Okay...] This includes zip-
        files where one or more files was skipped [Uh?] due to unsup-
        ported compression method or encryption with an unknown
        password.

 2      a generic error in the zipfile format was detected. Pro-
        cessing may [WTF] have completed successfully anyway; some bro-
        ken zipfiles created by other archivers have simple work-
        arounds.

 3      a severe error in the zipfile format was detected. Pro-
        cessing probably [WTF!] failed immediately.
 }}}

 Is there a full log somewhere? Maybe it would include such a "warning
 error".

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20147#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online