[tor-bugs] #20874 [Core Tor/Tor]: ReachableAddresses adds an extra reject *:* on every SAVECONF

[Tor Bug Tracker & Wiki]

#20874: ReachableAddresses adds an extra reject *:* on every SAVECONF
------------------------------+--------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.???
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-client
Actual Points:                |  Parent ID:
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------
 To fix this issue, we can do two things:

 1) We should add the reject *:* to a copy of the list after it has been
 parsed in parse_reachable_addresses() using append_exit_policy_string(),
 rather than adding it to the option itself in options_validate().

 2) We might also want to call exit_policy_remove_redundancies() on the
 parsed policy, so that long policies with redundancies are handled more
 efficiently. This is only likely to ever matter on busy hidden services.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20874>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online