[tor-bugs] #20761 [Applications/Tor Launcher]: Tor Browser 6.5a4 is ignoring additional SocksPorts

[Tor Bug Tracker & Wiki]

#20761: Tor Browser 6.5a4 is ignoring additional SocksPorts
---------------------------------------+-----------------------------------
 Reporter:  gk                         |          Owner:  brade
     Type:  defect                     |         Status:  needs_information
 Priority:  Medium                     |      Milestone:
Component:  Applications/Tor Launcher  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  TorBrowserTeam201612       |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------------------

Comment (by arthuredelstein):

 I think another way to look at it is that perhaps tor could handle
 redundant SocksPorts better. I just tried the following:
 {{{
 ~> tor +SocksPort 9999 +SocksPort 9998 +SocksPort 9999
 }}}
 and the result was:
 {{{
 Dec 02 11:43:32.724 [notice] Tor v0.2.7.6 (git-605ae665009853bd) running
 on Linux with Libevent 2.0.21-stable, OpenSSL 1.0.1t and Zlib 1.2.8.
 Dec 02 11:43:32.725 [notice] Tor can't help you if you use it wrong! Learn
 how to be safe at https://www.torproject.org/download/download#warning
 Dec 02 11:43:32.725 [notice] Read configuration file "/etc/tor/torrc".
 Dec 02 11:43:32.727 [notice] Opening Socks listener on 127.0.0.1:9150
 Dec 02 11:43:32.728 [notice] Opening Socks listener on 127.0.0.1:9999
 Dec 02 11:43:32.728 [notice] Opening Socks listener on 127.0.0.1:9998
 Dec 02 11:43:32.728 [notice] Opening Socks listener on 127.0.0.1:9999
 Dec 02 11:43:32.728 [warn] Could not bind to 127.0.0.1:9999: Address
 already in use. Is Tor already running?
 }}}

 It seems to me a better behavior would be to simply ignore the redundant
 request for +SocksPort 9999. In other words, tor should store SocksPorts
 in a set rather than a list. Then if we were to issue `saveconfig` over
 the control port, it would only save a single SocksPort 9999. So if Tor
 Launcher keeps adding the same unix domain socket every time it launches,
 it won't accumulate redundant copies in the torrc file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20761#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online